Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jumping between canary steps #216

Closed
wants to merge 9 commits into from

Conversation

myname4423
Copy link
Contributor

Ⅰ. Describe what this PR does

  1. Enables "Jump" between canary release steps: One can patch the status.CanaryStatus.NextStepIndex to jump between steps
  2. Enable patching the traffic strategy of current step
  3. Introduces a ReleaseManager interface: The canary ReleaseManager has already implemented this interface, paving the way for easy integration of the blue-green release strategy in the future.
  4. Abstracts Strategy-Specific Details: Replaces direct references to canary status and strategy with strategy-agnostic functions. This enhancement lays the groundwork for supporting future blue-green deployments more effectively.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

This PR is based on the previous one (update api for future bluegreen), #214
It is advisable to review this PR after the merging of its predecessor.

@kruise-bot kruise-bot requested review from veophi and zmberg May 28, 2024 07:59
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 38.00000% with 124 lines in your changes missing coverage. Please review.

Project coverage is 43.19%. Comparing base (07c1731) to head (74b7498).
Report is 3 commits behind head on master.

Current head 74b7498 differs from pull request most recent head fccb995

Please upload reports for the commit fccb995 to get more accurate results.

Files Patch % Lines
pkg/controller/rollout/rollout_progressing.go 50.00% 34 Missing and 10 partials ⚠️
pkg/controller/rollout/rollout_status.go 19.14% 38 Missing ⚠️
pkg/controller/rollout/rollout_canary.go 27.02% 25 Missing and 2 partials ⚠️
...g/controller/batchrelease/batchrelease_executor.go 56.25% 7 Missing ⚠️
pkg/util/rollout_utils.go 0.00% 7 Missing ⚠️
pkg/util/controller_finder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   43.63%   43.19%   -0.45%     
==========================================
  Files          52       52              
  Lines        5681     5795     +114     
==========================================
+ Hits         2479     2503      +24     
- Misses       2778     2859      +81     
- Partials      424      433       +9     
Flag Coverage Δ
unittests 43.19% <38.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myname4423 myname4423 force-pushed the jump branch 2 times, most recently from f45aa60 to 28303e1 Compare May 29, 2024 08:09
@kruise-bot
Copy link

@myname4423: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@myname4423 myname4423 closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants