Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2 fields to status to support showing result of kubectl get #220

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

myname4423
Copy link
Contributor

Ⅰ. Describe what this PR does

if we run kubectl get rollout rollouts-demo, we get result like this:
image

the CANARY_STEP and CANARY_STATE are read from rollout.status.CanaryStatus, however, if we support blue-green, we cannot read the values from this path anymore, because the CanaryStatus will be nil. Therefore, i add copies of these two fields to rollout.status. They are only used to showing the brief result returned from kubectl get command.

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Special notes for reviews

@zmberg
Copy link
Member

zmberg commented Jun 25, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Jun 25, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit db761a9 into openkruise:master Jun 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants