Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: gateway-api along with controller-runtime #237

Merged

Conversation

AiRanthem
Copy link
Member

gateway-api: 0.5.1=>0.7.1
controller-runtime: 0.12.1=>0.14.6

Ⅰ. Describe what this PR does

upgrade gateway-api and controller-runtime

Ⅱ. Does this pull request fix one issue?

fixes #236

Ⅲ. Special notes for reviews

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.95%. Comparing base (07c1731) to head (dcd317d).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
pkg/trafficrouting/network/gateway/gateway.go 0.00% 2 Missing ⚠️
...k/customNetworkProvider/custom_network_provider.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   43.63%   44.95%   +1.32%     
==========================================
  Files          52       55       +3     
  Lines        5681     6101     +420     
==========================================
+ Hits         2479     2743     +264     
- Misses       2778     2895     +117     
- Partials      424      463      +39     
Flag Coverage Δ
unittests 44.95% <50.00%> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AiRanthem AiRanthem force-pushed the upgrade/gateway-api-0.7.1-241111 branch from 7eb63e1 to 9a0da15 Compare November 12, 2024 11:17
@AiRanthem AiRanthem force-pushed the upgrade/gateway-api-0.7.1-241111 branch from 9a0da15 to ef8ccf0 Compare November 12, 2024 11:27
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@furykerry furykerry merged commit 09e01cb into openkruise:master Nov 13, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade gateway-api version to 0.7.1
2 participants