Modified sale line serialization for cart #7211 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishC
force-pushed
the
feature/task-7211
branch
from
816c587
to
0e02378
Compare
| @@ -164,6 +164,13 @@ def serialize(self, purpose=None): | |||
| if purpose == 'cart': | |||
| res.update({ | |||
| 'id': self.id, | |||
| 'display_name': self.description or self.product.name, | |||
There was a problem hiding this comment.
I think description is required
By default, the standard fields 'display_name', 'url', 'image' are picked from the sale line's product. In downstream modules this behaviour can be modified.
PritishC
force-pushed
the
feature/task-7211
branch
from
0e02378
to
faf8e16
Compare
tarunbhardwaj
added a commit
that referenced
this pull request
Mar 9, 2015
Modified sale line serialization for cart #7211
|
@PritishC please send same patch for 3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the standard fields 'display_name', 'url', 'image' are picked from the sale line's product. In downstream modules this behaviour can be modified.
Ref: #84