Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survival Normalization #2673

Closed
wants to merge 43 commits into from

Commits on Aug 10, 2023

  1. Update particle_data.h

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    dcceb9e View commit details
    Browse the repository at this point in the history
  2. Update settings.h

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5e21998 View commit details
    Browse the repository at this point in the history
  3. Update physics.cpp

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    64655f9 View commit details
    Browse the repository at this point in the history
  4. Update physics_common.cpp

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e4a590c View commit details
    Browse the repository at this point in the history
  5. Update physics_mg.cpp

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6e9bb02 View commit details
    Browse the repository at this point in the history
  6. Update settings.cpp

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d020cd6 View commit details
    Browse the repository at this point in the history
  7. Update simulation.cpp

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    419da6f View commit details
    Browse the repository at this point in the history
  8. Update settings.rst

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3e0b765 View commit details
    Browse the repository at this point in the history
  9. Update neutron_physics.rst

    quantaroo authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6663f92 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Update particle_data.h

    quantaroo authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b865de1 View commit details
    Browse the repository at this point in the history
  2. Description of Boolean enabling Survival Normalization.

    Description of Boolean enabling Survival Normalization.
    
    Description briefly of functionality and current limitations.
    yrrepy authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7cb3cbb View commit details
    Browse the repository at this point in the history
  3. Description of Survival Normalization

    Described Survival Normalization for phase-space sources. Unfortunately there is little description or justification for this out in the general topic literature. Though I have found it to work better in multiple test cases, notably the FOM in areas with middling statistics (~10%).
    
    In term should add capability of normalization for biased general sources.
    yrrepy authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    58f847f View commit details
    Browse the repository at this point in the history
  4. Extra commenting in simulation.cpp

    Code commenting for actual normalization mechanism
    yrrepy authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b9daf2f View commit details
    Browse the repository at this point in the history
  5. Code commenting

    yrrepy authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    63c1eba View commit details
    Browse the repository at this point in the history
  6. Code commenting

    Code commenting
    yrrepy authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a7bba13 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1b754d3 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #2 from yrrepy/Survival-Normalization-PR-3

    Survival normalization pr 3
    quantaroo authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    508632b View commit details
    Browse the repository at this point in the history
  9. Update settings.rst

    quantaroo authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a771c3e View commit details
    Browse the repository at this point in the history
  10. Update settings.rst

    quantaroo authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    60c8c76 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Remove duplicate description

    Remove duplicate description of Surv Norm
    yrrepy authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    deea36e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #14 from yrrepy/jmau-Survival-Normalization-PR

    Remove duplicate description
    yrrepy authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8bccb13 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Survival Normalization by Default Off

    Survival Normalization by Default Off
    yrrepy authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    67e2319 View commit details
    Browse the repository at this point in the history
  2. Update text on Survival Normalization

    Update text on Survival Normalization, default=false
    yrrepy authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    79249e0 View commit details
    Browse the repository at this point in the history
  3. Nuanced the details of survival normalization

    Better explaining when to use survival normalization
    yrrepy authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    528e6ae View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. wgt0 single variable

    Single variable for Survival Normalization
    yrrepy authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7bf5c72 View commit details
    Browse the repository at this point in the history
  2. Reorganize mechanics of Survival Normalization

    Use single variable wgt0, and multiply cutoffs here (on the fly), 
    
    rather than having to multply in simulation.cpp.
    and then telling the physics modules to get this or that cutoff.
    yrrepy authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    49cad97 View commit details
    Browse the repository at this point in the history
  3. Revert

    Revert to original, now that cutoffs were multiplied on the fly
    yrrepy authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c220a14 View commit details
    Browse the repository at this point in the history
  4. Revert

    Revert with simplified survival normalization
    yrrepy authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ceb7a12 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Single Variable for biasing

    Assign Particle Start Weight
    yrrepy authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e039b1d View commit details
    Browse the repository at this point in the history
  2. Grammar

    Punctuation
    yrrepy authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2798b60 View commit details
    Browse the repository at this point in the history
  3. Remove lingering cuttoff variables in particle_data.h

    Remove lingering cuttoff variables in particle_data.h
    yrrepy authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    10ef362 View commit details
    Browse the repository at this point in the history
  4. Bracket typo

    Bracket typo in physics.cpp
    yrrepy authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    bae4f44 View commit details
    Browse the repository at this point in the history
  5. Update simulation.cpp

    yrrepy authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d3893d0 View commit details
    Browse the repository at this point in the history
  6. Another braces typo

    Not entering final if statement (russian roulette for not survival normalization)
    yrrepy authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9c83ae2 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Merge pull request #18 from yrrepy/Surv-Norm_PR-review

    Commits to address review
    yrrepy authored Sep 30, 2023
    Configuration menu
    Copy the full SHA
    5554f4b View commit details
    Browse the repository at this point in the history
  2. Simplified Survival Norm mechanics

    multiplication by wgt0 if Survival Normalization on
    yrrepy authored Sep 30, 2023
    Configuration menu
    Copy the full SHA
    b47b7a3 View commit details
    Browse the repository at this point in the history
  3. Majuscule Russian

    Pedantic capitalization to match physics_mg.cpp
    yrrepy authored Sep 30, 2023
    Configuration menu
    Copy the full SHA
    b5543cf View commit details
    Browse the repository at this point in the history
  4. Reorganize Boolean flags

    Reorganize and reorder Boolean flags to account for changes that have occurred in the interim with the recent addition of weight_window_checkpoint_surface and weight_window_checkpoint_collision.
    
    Thus Resolving a conflict in the present PR.
    yrrepy authored Sep 30, 2023
    Configuration menu
    Copy the full SHA
    6c0b7db View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Update include/openmc/particle_data.h

    Co-authored-by: Ethan Peterson <[email protected]>
    yrrepy and eepeterson authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7322d2f View commit details
    Browse the repository at this point in the history
  2. Update include/openmc/settings.h

    no boolean gating off survival normalization for SSR only
    
    Co-authored-by: Ethan Peterson <[email protected]>
    yrrepy and eepeterson authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ca34036 View commit details
    Browse the repository at this point in the history
  3. Update physics_mg.cpp

    no SSR gating
    yrrepy authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    edcb028 View commit details
    Browse the repository at this point in the history
  4. Update physics.cpp

    yrrepy authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d425ff1 View commit details
    Browse the repository at this point in the history
  5. Update neutron_physics.rst

    remover "relevant for only SSR"
    yrrepy authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c589088 View commit details
    Browse the repository at this point in the history