Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user-configurable random number stride #3067

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ahman24
Copy link

@ahman24 ahman24 commented Jul 3, 2024

Description

Some believe exceeding random number stride is insensitive in Monte Carlo particle transport code solely based on the legacy stride exceedance study by Hendricks, 1991. However, recent study critically reviewed the legacy study in [1] and exhaustively reanalyzed the Hendricks problems in [2] and [3] (the full article is still under peer review) and proved that stride exceedance severely corrupts Monte Carlo simulation.

The most convenient solution for now is to support user-configurable stride so user can use longer stride for transport problems that are susceptible of stride exceedance as discussed in [1]. This PR adds support for user-configurable random number stride.

Fixes #2993

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@ahman24 ahman24 requested a review from paulromano as a code owner July 3, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make random number stride user-configurable
1 participant