Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added subfolders when looking for dose coefficient txt files in Pyproject #3173

Closed

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Oct 18, 2024

Description

When doing pip install . within openmc the .txt files from the subfolders of the /home/jon/openmc/openmc/data/effective_dose/ are not being copied over to the system install directory.

I noticed this as a CI failure while updating my neutronics-workshop examples

I believe the reason we didn't catch it in openmc CI when PR #3020 was merged in is because we don't use the src folder layout so when we run pytest it imports the local openmc folder as the package and this folder includes all the txt files as mentioned in this issue

Anyway it is a small fix to add ** so that the pyproject includes the subdirectories icrp116 and icrp74 and other future subdirectories

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)

@shimwell shimwell added the Data label Oct 18, 2024
@shimwell
Copy link
Member Author

I used the github webpage to make this PR and I accidentally made a branch on the main repo, so I'm closing this PR and remaking it from my fork

replaced by #3174

@shimwell shimwell closed this Oct 18, 2024
@shimwell shimwell deleted the shimwell-added-subfolder-search-for-dose-txt-files branch October 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant