feat(invoice): save number at finalize

openmeterio · Jan 21, 2025 · 4a69be5 · 4a69be5
1 parent b26951c
commit 4a69be5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/openmeter/billing/app.go b/openmeter/billing/app.go
@@ -74,6 +74,7 @@ func NewUpsertInvoiceResult() *UpsertInvoiceResult {
 }
 
 type FinalizeInvoiceResult struct {
+	invoiceNumber     string
 	paymentExternalID string
 }
 
@@ -89,8 +90,12 @@ func (f *FinalizeInvoiceResult) SetPaymentExternalID(paymentExternalID string) {
 	f.paymentExternalID = paymentExternalID
 }
 
-func (f *FinalizeInvoiceResult) SetInvoiceNumber(number string) {
-	f.SetInvoiceNumber(number)
+func (u *FinalizeInvoiceResult) GetInvoiceNumber() (string, bool) {
+	return u.invoiceNumber, u.invoiceNumber != ""
+}
+
+func (f *FinalizeInvoiceResult) SetInvoiceNumber(invoiceNumber string) {
+	f.invoiceNumber = invoiceNumber
 }
 
 type InvoicingApp interface {

diff --git a/openmeter/billing/service/invoicestate.go b/openmeter/billing/service/invoicestate.go
@@ -474,6 +474,10 @@ func (m *InvoiceStateMachine) finalizeInvoice(ctx context.Context) error {
 			if paymentExternalID, ok := results.GetPaymentExternalID(); ok {
 				m.Invoice.ExternalIDs.Payment = paymentExternalID
 			}
+
+			if invoiceNumber, ok := results.GetInvoiceNumber(); ok {
+				m.Invoice.Number = lo.ToPtr(invoiceNumber)
+			}
 		}
 
 		return nil