Merge pull request #1583 from openmeterio/fix-notification-api-spec

fix(api): update endpoints for Notification API
openmeterio · Sep 27, 2024 · d64ea4e · d64ea4e
2 parents 44787e4 + d1b7843
commit d64ea4e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/api/spec/src/notification/channel.tsp b/api/spec/src/notification/channel.tsp
@@ -197,7 +197,7 @@ interface Channels {
   @put
   @operationId("updateNotificationChannel")
   @summary("Update a notification channel")
-  update(@body request: ChannelCreateRequest): {
+  update(@path channelId: ULID, @body request: ChannelCreateRequest): {
     @statusCode _: 200;
     @body body: Channel;
   } | OpenMeter.CommonErrors;

diff --git a/api/spec/src/notification/rule.tsp b/api/spec/src/notification/rule.tsp
@@ -278,7 +278,7 @@ interface Rules {
   @put
   @operationId("updateNotificationRule")
   @summary("Update a notification rule")
-  update(@body request: RuleCreateRequest): {
+  update(@path ruleId: ULID, @body request: RuleCreateRequest): {
     @statusCode _: 200;
     @body body: Rule;
   } | OpenMeter.CommonErrors;
@@ -311,5 +311,6 @@ interface Rules {
   @operationId("testNotificationRule")
   test(@path ruleId: ULID): {
     @statusCode _: 201;
+    @body body: Event;
   } | OpenMeter.NotFoundError | OpenMeter.CommonErrors;
 }