Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use wire for jobs service #2177

Merged
merged 1 commit into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/common/billing.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
billingadapter "github.com/openmeterio/openmeter/openmeter/billing/adapter"
billingservice "github.com/openmeterio/openmeter/openmeter/billing/service"
billingsubscription "github.com/openmeterio/openmeter/openmeter/billing/subscription"
billingworkerautoadvance "github.com/openmeterio/openmeter/openmeter/billing/worker/advance"
"github.com/openmeterio/openmeter/openmeter/customer"
entdb "github.com/openmeterio/openmeter/openmeter/ent/db"
"github.com/openmeterio/openmeter/openmeter/meter"
Expand Down Expand Up @@ -74,3 +75,10 @@ func BillingSubscriptionValidator(

return billingsubscription.NewValidator(billingService)
}

func NewBillingAutoAdvancer(logger *slog.Logger, service billing.Service) (*billingworkerautoadvance.AutoAdvancer, error) {
return billingworkerautoadvance.NewAdvancer(billingworkerautoadvance.Config{
BillingService: service,
Logger: logger,
})
}
15 changes: 15 additions & 0 deletions app/common/telemetry.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,21 @@ import (
"github.com/openmeterio/openmeter/pkg/gosundheit"
)

var TelemetryWithoutServer = wire.NewSet(
NewTelemetryResource,

NewLoggerProvider,
wire.Bind(new(log.LoggerProvider), new(*sdklog.LoggerProvider)),
NewLogger,

NewMeterProvider,
wire.Bind(new(metric.MeterProvider), new(*sdkmetric.MeterProvider)),
NewMeter,
NewTracerProvider,
wire.Bind(new(trace.TracerProvider), new(*sdktrace.TracerProvider)),
NewTracer,
)

var Telemetry = wire.NewSet(
NewTelemetryResource,

Expand Down
198 changes: 4 additions & 194 deletions cmd/jobs/billing/advance/advance.go
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
package advance

import (
"context"
"fmt"
"log/slog"

"github.com/spf13/cobra"
sdkmetric "go.opentelemetry.io/otel/sdk/metric"

"github.com/openmeterio/openmeter/app/common"
appconfig "github.com/openmeterio/openmeter/app/config"
"github.com/openmeterio/openmeter/cmd/jobs/config"
"github.com/openmeterio/openmeter/cmd/jobs/internal"
"github.com/openmeterio/openmeter/openmeter/billing"
billingadapter "github.com/openmeterio/openmeter/openmeter/billing/adapter"
billingservice "github.com/openmeterio/openmeter/openmeter/billing/service"
billingworkerautoadvance "github.com/openmeterio/openmeter/openmeter/billing/worker/advance"
registrybuilder "github.com/openmeterio/openmeter/openmeter/registry/builder"
"github.com/openmeterio/openmeter/openmeter/watermill/driver/kafka"
"github.com/openmeterio/openmeter/pkg/framework/entutils/entdriver"
"github.com/openmeterio/openmeter/pkg/framework/pgdriver"
)

var namespace string
Expand All @@ -36,167 +24,17 @@ func init() {
Cmd.PersistentFlags().StringVar(&namespace, "namespace", "", "namespace the operation should be performed")
}

type autoAdvancer struct {
*billingworkerautoadvance.AutoAdvancer

Shutdown func()
}

func NewAutoAdvancer(ctx context.Context, conf appconfig.Configuration, logger *slog.Logger) (*autoAdvancer, error) {
commonMetadata := common.NewMetadata(conf, "0.0.0", "billing-advancer")

// We use a noop meter provider as we don't want to monitor cronjobs (for now)
meterProvider := sdkmetric.NewMeterProvider()
meter := meterProvider.Meter("billing-advancer")

// Initialize Postgres driver
postgresDriver, err := pgdriver.NewPostgresDriver(ctx, conf.Postgres.URL)
if err != nil {
return nil, fmt.Errorf("failed to initialize postgres driver: %w", err)
}

// Initialize Ent driver
entPostgresDriver := entdriver.NewEntPostgresDriver(postgresDriver.DB())

meterRepository := common.NewInMemoryRepository(conf.Meters)

clickhouseConn, err := common.NewClickHouse(conf.Aggregation.ClickHouse)
if err != nil {
return nil, fmt.Errorf("failed to initialize clickhouse connection: %w", err)
}

streamingConnector, err := common.NewStreamingConnector(ctx, conf.Aggregation, clickhouseConn, meterRepository, logger)
if err != nil {
return nil, fmt.Errorf("failed to initialize streaming connection: %w", err)
}

brokerOptions := common.NewBrokerConfiguration(conf.Ingest.Kafka.KafkaConfiguration, conf.Telemetry.Log, commonMetadata, logger, meter)

adminClient, err := common.NewKafkaAdminClient(conf.Ingest.Kafka.KafkaConfiguration)
if err != nil {
return nil, fmt.Errorf("failed to initialize kafka admin client: %w", err)
}

kafkaTopicProvisionerConfig := common.NewKafkaTopicProvisionerConfig(adminClient, logger, meter, conf.Ingest.Kafka.TopicProvisionerConfig)

topicProvisioner, err := common.NewKafkaTopicProvisioner(kafkaTopicProvisionerConfig)
if err != nil {
return nil, fmt.Errorf("failed to initialize kafka topic provisioner: %w", err)
}

publisher, serverPublisherShutdown, err := common.NewServerPublisher(ctx, kafka.PublisherOptions{
Broker: brokerOptions,
ProvisionTopics: common.ServerProvisionTopics(conf.Events),
TopicProvisioner: topicProvisioner,
}, logger)
if err != nil {
return nil, fmt.Errorf("failed to initialize server publisher: %w", err)
}

ebPublisher, err := common.NewEventBusPublisher(publisher, conf.Events, logger)
if err != nil {
return nil, fmt.Errorf("failed to initialize event bus publisher: %w", err)
}

entitlementRegistry := registrybuilder.GetEntitlementRegistry(registrybuilder.EntitlementOptions{
DatabaseClient: entPostgresDriver.Client(),
StreamingConnector: streamingConnector,
Logger: logger,
MeterRepository: meterRepository,
Publisher: ebPublisher,
})

customerService, err := common.NewCustomerService(logger, entPostgresDriver.Client(), entitlementRegistry)
if err != nil {
return nil, fmt.Errorf("failed to initialize customer service: %w", err)
}

secretService, err := common.NewUnsafeSecretService(logger, entPostgresDriver.Client())
if err != nil {
return nil, fmt.Errorf("failed to initialize secret service: %w", err)
}

appService, err := common.NewAppService(logger, entPostgresDriver.Client(), conf.Apps)
if err != nil {
return nil, fmt.Errorf("failed to initialize app service: %w", err)
}

_, err = common.NewAppStripeService(logger, entPostgresDriver.Client(), conf.Apps, appService, customerService, secretService)
if err != nil {
return nil, fmt.Errorf("failed to initialize stripe app service: %w", err)
}

namespaceManager, err := common.NewNamespaceManager(nil, conf.Namespace)
if err != nil {
return nil, fmt.Errorf("failed to initialize namespace manager: %w", err)
}

billingAdapter, err := billingadapter.New(billingadapter.Config{
Client: entPostgresDriver.Client(),
Logger: logger,
})
if err != nil {
return nil, fmt.Errorf("failed to initialize billing adapter: %w", err)
}

billingService, err := billingservice.New(billingservice.Config{
Adapter: billingAdapter,
CustomerService: customerService,
AppService: appService,
Logger: logger,
FeatureService: entitlementRegistry.Feature,
MeterRepo: meterRepository,
StreamingConnector: streamingConnector,
Publisher: ebPublisher,
})
if err != nil {
return nil, fmt.Errorf("failed to initialize billing service: %w", err)
}

_, err = common.NewAppSandboxProvisioner(ctx, logger, conf.Apps, appService, namespaceManager, billingService)
if err != nil {
return nil, fmt.Errorf("failed to initialize sandbox app provisioner: %w", err)
}

a, err := billingworkerautoadvance.NewAdvancer(billingworkerautoadvance.Config{
BillingService: billingService,
Logger: logger,
})
if err != nil {
return nil, fmt.Errorf("failed to initialize billing auto-advancer: %w", err)
}

return &autoAdvancer{
AutoAdvancer: a,
Shutdown: serverPublisherShutdown,
}, nil
}

var ListCmd = func() *cobra.Command {
cmd := &cobra.Command{
Use: "list",
Short: "List invoices which can be advanced",
RunE: func(cmd *cobra.Command, args []string) error {
ctx := cmd.Context()

conf, err := config.GetConfig()
if err != nil {
return err
}

a, err := NewAutoAdvancer(ctx, conf, slog.Default())
if err != nil {
return err
}

defer a.Shutdown()

var ns []string
if namespace != "" {
ns = append(ns, namespace)
}

invoices, err := a.ListInvoicesToAdvance(ctx, ns, nil)
invoices, err := internal.App.BillingAutoAdvancer.ListInvoicesToAdvance(cmd.Context(), ns, nil)
if err != nil {
return err
}
Expand All @@ -218,26 +56,12 @@ var InvoiceCmd = func() *cobra.Command {
Short: "Advance invoice(s)",
Args: cobra.MinimumNArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
ctx := cmd.Context()

conf, err := config.GetConfig()
if err != nil {
return err
}

a, err := NewAutoAdvancer(ctx, conf, slog.Default())
if err != nil {
return err
}

defer a.Shutdown()

if namespace == "" {
return fmt.Errorf("invoice namespace is required")
}

for _, invoiceID := range args {
_, err := a.AdvanceInvoice(ctx, billing.InvoiceID{
_, err := internal.App.BillingAutoAdvancer.AdvanceInvoice(cmd.Context(), billing.InvoiceID{
Namespace: namespace,
ID: invoiceID,
})
Expand All @@ -260,26 +84,12 @@ var AllCmd = func() *cobra.Command {
Use: "all",
Short: "Advance all eligible invoices",
RunE: func(cmd *cobra.Command, args []string) error {
ctx := cmd.Context()

conf, err := config.GetConfig()
if err != nil {
return err
}

a, err := NewAutoAdvancer(ctx, conf, slog.Default())
if err != nil {
return err
}

defer a.Shutdown()

var ns []string
if namespace != "" {
ns = append(ns, namespace)
}

return a.All(ctx, ns, batchSize)
return internal.App.BillingAutoAdvancer.All(cmd.Context(), ns, batchSize)
},
}

Expand Down
46 changes: 0 additions & 46 deletions cmd/jobs/config/loader.go

This file was deleted.

Loading
Loading