Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Chore) Refactor Service metrics extension slot #7

Merged
merged 5 commits into from
Feb 15, 2024
Merged

(Chore) Refactor Service metrics extension slot #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33a1dd8
(Chore) Refactor Service metrics extension slot
ODORA0 Feb 15, 2024
99a042c
PR comments
ODORA0 Feb 15, 2024
7ff74c6
PR comments
ODORA0 Feb 15, 2024
222d2bd
PR comments
ODORA0 Feb 15, 2024
f977d93
PR comments
ODORA0 Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/billable-services/dashboard/dashboard.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import BillableServices from '../billable-services.component';
import ServiceMetrics from './service-metrics.component';
import styles from './dashboard.scss';
import { ExtensionSlot } from '@openmrs/esm-framework';

export default function BillableServicesDashboard() {
return (
Expand All @@ -10,6 +11,7 @@ export default function BillableServicesDashboard() {
<main className={styles.servicesTableContainer}>
<BillableServices />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need ServiceMetrics component since its now rendered throught the extension

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh yeah, done!

</main>
<ExtensionSlot name="billing-home-tiles-slot" />
</main>
);
}
1 change: 0 additions & 1 deletion src/billable-services/dashboard/service-metrics.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ function ServiceMetrics() {
{cards.map((card) => (
<Card key={card.title} title={card.title} count={card.count} />
))}
<ExtensionSlot name="billing-home-tiles-slot" />
</section>
);
}
Expand Down
2 changes: 0 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ export const billingSummaryDashboardLink = getSyncLifecycle(
options,
);

// export const billingServicesTiles = getSyncLifecycle(ServiceMetrics, options);

export const billableServicesCardLink = getSyncLifecycle(BillableServicesCardLink, options);
export const billableServicesHome = getSyncLifecycle(BillableServiceHome, options);
export const billingCheckInForm = getSyncLifecycle(BillingCheckInForm, options);
Expand Down
Loading