Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): new app switcher #1149

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jabahum
Copy link

@jabahum jabahum commented Sep 16, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Screenshots

image

Related Issue

Other

@jabahum jabahum changed the title ft : new app switcher (feat): new app switcher Sep 17, 2024
@jabahum
Copy link
Author

jabahum commented Sep 26, 2024

Cc @denniskigen need review from you on this if you have some bandwidth

@denniskigen
Copy link
Member

denniskigen commented Sep 26, 2024

Thanks for working on this, @jabahum. FYI @ciaranduffy @paulsonder

@jabahum jabahum marked this pull request as ready for review October 18, 2024 05:14
@brandones
Copy link
Collaborator

Can someone please link to designs or requirements, a ticket, something?

@jabahum is that really a screenshot of the app? Where did all those apps ("Data Visualizer" etc) come from?

@brandones
Copy link
Collaborator

Ping?

@brandones
Copy link
Collaborator

@denniskigen hey, what's the deal with this PR?

@jabahum
Copy link
Author

jabahum commented Dec 16, 2024

@denniskigen hey, what's the deal with this PR?

Hey @brandones , With this PR we are basically improving the view of apps and modules. As provided in the screenshot , this is being adopted from UgandaEMR+ and being added here. Your review and guidance is highly welcome cc @denniskigen

@brandones
Copy link
Collaborator

Ok since there's no ticket or designs or anything I've started a thread on Slack about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants