-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-4253: Support translation for the implementation name in the page header #1232
Conversation
Size Change: -94.5 kB (-1.51%) Total Size: 6.16 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vasharma05
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @vasharma05. Have you figured out why tests on chart are failing? Can't see how it's related to this diff.
6f39c3a
to
c2ee642
Compare
Thanks for the fix, @ibacher. Took here as well! |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
The
implementationName
in the PageHeader component was not supported for translation, and this has been fixed by adding support for translating using thegetCoreTranslations
function.Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-4253
Other