Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Resolve Error in JavaScript Expression Validation #418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes the JavaScript expression-based validator by ensuring that formFields are correctly set in the validator's context.

Screenshots

Issue:

2024-10-25 14-55-04 2024-10-25 14_55_54

Fixed:
2024-10-25 14-57-28 2024-10-25 14_59_02

Related Issue

Other

Copy link

Size Change: -2 B (0%)

Total Size: 1.23 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 379 kB 0 B
dist/225.js 2.57 kB 0 B
dist/254.js 88.7 kB 0 B
dist/277.js 1.85 kB 0 B
dist/300.js 642 B 0 B
dist/335.js 968 B 0 B
dist/343.js 253 kB -2 B (0%)
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/635.js 14.4 kB 0 B
dist/690.js 11.5 kB 0 B
dist/697.js 111 kB 0 B
dist/70.js 483 B 0 B
dist/979.js 6.87 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 344 kB 0 B
dist/openmrs-esm-form-engine-lib.js 3.8 kB 0 B

compressed-size-action

@@ -23,7 +23,7 @@ export const ExpressionValidator: FormFieldValidator = {
return evaluateExpression(
config[key],
{ value: field, type: 'field' },
config.fields,
config.formFields,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the issue the key/naming being used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants