Notification error should be below

openmrs · Aug 12, 2024 · 41f1411 · 41f1411
1 parent e615655
commit 41f1411
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/src/results/result-form-field.component.tsx b/src/results/result-form-field.component.tsx
@@ -51,17 +51,6 @@ const ResultFormField: React.FC<ResultFormFieldProps> = ({
 
   return (
     <>
-      {Object.keys(errors).length > 0 && (
-        <InlineNotification
-          className={styles.emptyFormError}
-          lowContrast
-          title={t("error", "Error")}
-          subtitle={
-            t("pleaseFillField", "Please fill at least one field") + "."
-          }
-          hideCloseButton
-        />
-      )}
       {isTextOrNumeric(concept) && (
         <Controller
           control={control}
@@ -189,6 +178,18 @@ const ResultFormField: React.FC<ResultFormFieldProps> = ({
             );
           }
         })}
+
+      {Object.keys(errors).length > 0 && (
+        <InlineNotification
+          className={styles.emptyFormError}
+          lowContrast
+          title={t("error", "Error")}
+          subtitle={
+            t("pleaseFillField", "Please fill at least one field") + "."
+          }
+          hideCloseButton
+        />
+      )}
     </>
   );
 };

diff --git a/src/results/result-form.scss b/src/results/result-form.scss
@@ -33,11 +33,14 @@
   margin-top: auto;
 }
 
+.emptyFormError {
+  margin-top: 10px;
+}
+
 .form {
   display: flex;
   flex-direction: column;
   justify-content: space-between;
-  height: calc(100vh - 6rem);
 }
 
 :global(.omrs-breakpoint-lt-desktop) .form {