Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3676 Implement ability to add patient to a queue from lab app #111

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

its-kios09
Copy link
Contributor

@its-kios09 its-kios09 commented Dec 17, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

see:- https://openmrs.atlassian.net/browse/O3-3676
https://thepalladiumgroup.atlassian.net/browse/KHP3-7212

  • also, provided a fix on the metric counter on the test ordered and added gender

Screenshots

lab

Related Issue

Other

@pirupius pirupius changed the title feat: O3-3676 Implement ability to add patient to a queue from lab app (feat) O3-3676 Implement ability to add patient to a queue from lab app Dec 17, 2024
@its-kios09
Copy link
Contributor Author

@pirupius ping

@pirupius
Copy link
Member

pirupius commented Dec 18, 2024

@its-kios09 you mentioned a PR to core related to this work, does it mean it's dependent on another PR? Please link it if that's the case

@its-kios09
Copy link
Contributor Author

its-kios09 commented Dec 19, 2024

@its-kios09 you mentioned a PR to core related to this work, does it mean it's dependent on another PR? Please link it if that's the case

this is PR, it is independent, the one that depends on the core it is about mutating the in-progress after entering the results, currently it is not mutating you have to refresh the page

@its-kios09
Copy link
Contributor Author

@denniskigen ping

@its-kios09
Copy link
Contributor Author

@pirupius ping

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully we can start backfilling some tests

@pirupius pirupius merged commit ef73f5f into openmrs:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants