-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panel:Add an extensionSlot for lab tab panels #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -71,6 +95,11 @@ const LaboratoryQueueTabs: React.FC = () => { | |||
<CompletedList fulfillerStatus={"COMPLETED"} /> | |||
</div> | |||
</TabPanel> | |||
<ExtensionSlot name={labPanelSlot}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am also hoping adding the check won't render this in the view unless there's an existing extension selected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Pius ....
by default its not rendering this in the view unless the corresponding extension has been been selected,
})} | ||
</Tab> | ||
))} | ||
{tabExtensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the check here as well. Refer to previous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @pirupius i added a check that makes sure that the title
and name
values of the extension.meta
object are truthy before rendering the Tab which is automatically mapped to the corresponding TabPanel .
Kindly see the updated screenshot
Requirements
Summary
Screenshots
Related Issue
Other