Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tile:adding summary tiles as extesnions #38

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Conversation

gitcliff
Copy link
Contributor

@gitcliff gitcliff commented Jan 17, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The PR is also addressing the similar issue of the lab-tiles-slot which will not be visible in the implementer tools UI when used below
in the value for ComponentContext.Provider as the UI viewer depends on the div that cannot be added because of how the Carbon components work. Implementers can add more tab extensions to this slot via the routes.js file configuration.

Screenshots

Screenshot 2024-01-24 at 3 44 43 PM

Related Issue

Other

@gitcliff gitcliff marked this pull request as draft January 17, 2024 13:09
@jabahum jabahum requested a review from pirupius January 19, 2024 05:38
@gitcliff gitcliff marked this pull request as ready for review January 24, 2024 13:04
@gitcliff
Copy link
Contributor Author

cc @pirupius

@jabahum
Copy link
Collaborator

jabahum commented Jan 25, 2024

Thanks @gitcliff. how about if they are evenly spaced to fill up the extra space

@gitcliff
Copy link
Contributor Author

Thanks @gitcliff. how about if they are evenly spaced to fill up the extra space

hello @jabahum i think this is caused by this Extension design ..
i have attached two screenshots below showing the generated mark-up difference between when Extensions are used and when not used...
Screenshot 2024-01-29 at 4 06 52 PM
Screenshot 2024-01-29 at 4 39 03 PM

@pirupius pirupius merged commit 45c189c into openmrs:main Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants