Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U4X-360 : Add referral in the lab results on the clinician side #46

Conversation

jabahum
Copy link
Collaborator

@jabahum jabahum commented Jan 23, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • Referral Tab Integration:
    Added a new Referral Tab to the investigative results with a referral tables to visualise referred orders for a patient .
  • Active and Past Test Order Tables:
    Implemented two tables for Active and Past Test Orders.
  • Email Results Delivery:
    Added the capability to send test results via email for active ,past test and referral orders tables.
  • Result Reporting in Referrals Tab:
    Enabled result reporting for test orders on the Referral Table in the Referrals Tab.
  • Request Test Orders Feature:
    Added a feature to request a test order directly from the Active Test Order table using add button.

Screenshots

Screen.Recording.2024-02-02.at.13.14.51.mov

Related Issue

https://metsprogramme.atlassian.net/browse/U4X-365

Other

@jabahum jabahum force-pushed the U4X-360-Add-referral-in-the-lab-results-on-the-clinician-side branch from a331a0b to 7ea9573 Compare January 24, 2024 06:07
@sherrif10
Copy link
Member

sherrif10 commented Jan 24, 2024

@jabahum Well done on this, How i wish you split it in different tasks.

@jabahum jabahum requested a review from pirupius January 31, 2024 05:25
@pirupius
Copy link
Member

@jabahum is this PR still WIP or still necessary? It has really grown (now at 33 files)
Please add a description and screenshots/recording as well for more context

@jabahum
Copy link
Collaborator Author

jabahum commented Jan 31, 2024

@jabahum is this PR still WIP or still necessary? It has really grown (now at 33 files) Please add a description and screenshots/recording as well for more context

@pirupius this is still necessary.

@jabahum jabahum force-pushed the U4X-360-Add-referral-in-the-lab-results-on-the-clinician-side branch from 718e534 to d9ec1b3 Compare February 2, 2024 06:39
@jabahum jabahum marked this pull request as ready for review February 2, 2024 09:43
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There PR has a bunch of changes. Please add a video recording or screenshots of how the workflow. I see some components being created within the patient-chart directory so does this mean there other widgets being added?

"@carbon/react": "1.14.0"
},
"packageManager": "[email protected]"
"name": "@openmrs/esm-laboratory-app",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the indentation changes to this file. Typically this is meant to be 2 spaces

children: React.ReactNode;
}

export function CardHeader({ title, children }: CardHeaderProps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be no reference to this component. Can u confirm and delete if not used

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have been able to remove this and use the one in the commons-lib

@use '@carbon/styles/scss/type';
@import '~@openmrs/esm-styleguide/src/vars';

.desktopHeader, .tabletHeader {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same applies to this file which is referenced in the other component

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same applies here

@@ -0,0 +1 @@
export * from "./card-header.component";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also has been removed

@jabahum jabahum force-pushed the U4X-360-Add-referral-in-the-lab-results-on-the-clinician-side branch from 9bb4a4b to 4a2fd6f Compare February 6, 2024 08:56
src/routes.json Outdated
Comment on lines 53 to 56
{
"name" :"",
"component": ""
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs clean up

@pirupius pirupius merged commit ad2294c into openmrs:main Feb 6, 2024
3 checks passed
@sherrif10
Copy link
Member

Well done @jabahum @pirupius , there are couple of fixes we need to get rid of expecially on laboratoryorder form.

@sherrif10
Copy link
Member

Commiting a followup commit on editing referal form , its not visible when you try edditing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants