Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3782: Use styleguide page header component in lab app #83

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

Twiineenock
Copy link
Contributor

@Twiineenock Twiineenock commented Aug 10, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

A reuseable dashboard header component was implemented in the styleguide here. Therefore this PR adapts the laboratory app to use this.

Screenshots

Before:

lab-header-before

After:

laboratory-header

Related Issue

https://openmrs.atlassian.net/browse/O3-3782

Other

@denniskigen denniskigen changed the title (chore) O3-3782: Tweak PageHeader to use Styleguide version (feat) O3-3782: Use styleguide page header component in lab app Aug 12, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@denniskigen denniskigen merged commit b90646d into openmrs:main Aug 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants