e2e tests #94
Open
e2e tests #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the |
ibacher
reviewed
Oct 11, 2024
There was a problem hiding this comment.
I don't think this file should be committed at all.
There was a problem hiding this comment.
Nothing in the playwright-report should be part of this commit.
| "@carbon/react": "1.14.0" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| "name": "@openmrs/esm-laboratory-app", |
There was a problem hiding this comment.
This JSON file should not be reformatted like this. The formatting should be 2-space indentation.
| "serve": "webpack serve --mode=development", | ||
| "build": "webpack --mode production", | ||
| "analyze": "webpack --mode=production --env analyze=true", | ||
| "lint": "TIMING=1 eslint src --ext js,jsx,ts,tsx", |
There was a problem hiding this comment.
Not sure why you've modified this script?
| jq -n \ | ||
| --arg apps "$apps" \ | ||
| --arg app_names "$(echo ${app_names[@]})" \ | ||
| '{"@openmrs/esm-primary-navigation-app": "next", "@openmrs/esm-home-app": "next", "@openmrs/esm-patient-chart-app": "next"} + ( |
There was a problem hiding this comment.
We shouldn't explicitly need the patient-chart-app here.
| @@ -0,0 +1,49 @@ | |||
| #!/usr/bin/env bash -eu | |||
There was a problem hiding this comment.
This probably actually doesn't work here because there is not Yarn workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
Other