-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-4025: Add an icon for patient summary on the left nav #2051
base: main
Are you sure you want to change the base?
Conversation
@VeronicaMuthee, could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shishiro26 , is it possible to make this configurable ? Instead of hardcoding the icon ?
@CynthiaKamau Actually, I couldn't find the icon in the "@openmrs/esm-framework" , so I had to hardcode it. Could you please clarify what you mean by making it 'configurable'? I'm not sure if I fully understand. |
@paulsonder @ciaranduffy do we have any mockups for this? |
|
Hi @denniskigen, we don't use icons in the RefApp designs. However, if an implementation really wants to use icons, we would recommend using the default Carbon Design left nav item component, with the icon variation. You can see that documented here. The screenshot above doesn't look like it's using the default carbon left nav component as the icon doesn't look correctly aligned. |
Hi @ciaranduffy I took the design from the documentation shared in the ticket (Google Docs), as it was mentioned there.
yes sir there was a mistake from my side I will update the icon with the carbon react-icons and remove the hardcoded icons |
Requirements
fix:
,feat:
,chore:
).Summary
This PR addresses the addition of an icon to the left sidebar in the
esm-patient-chart-app
.Screenshots
Related Issue
Jira Ticket: O3-4025
Other Information