Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-4025: Add an icon for patient summary on the left nav #2051

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shishiro26
Copy link

@shishiro26 shishiro26 commented Oct 1, 2024

Requirements

Summary

This PR addresses the addition of an icon to the left sidebar in the esm-patient-chart-app.

Screenshots

image

Related Issue

Jira Ticket: O3-4025

Other Information

@shishiro26
Copy link
Author

@VeronicaMuthee, could you please review this PR?

@shishiro26 shishiro26 closed this Oct 7, 2024
@shishiro26 shishiro26 deleted the O3-2801/O3-4025 branch October 7, 2024 18:13
@shishiro26 shishiro26 restored the O3-2801/O3-4025 branch October 8, 2024 14:13
@shishiro26 shishiro26 reopened this Oct 8, 2024
Copy link
Collaborator

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shishiro26 , is it possible to make this configurable ? Instead of hardcoding the icon ?

@shishiro26
Copy link
Author

@CynthiaKamau Actually, I couldn't find the icon in the "@openmrs/esm-framework" , so I had to hardcode it. Could you please clarify what you mean by making it 'configurable'? I'm not sure if I fully understand.

@denniskigen
Copy link
Member

@paulsonder @ciaranduffy do we have any mockups for this?

@dkayiwa
Copy link
Member

dkayiwa commented Oct 21, 2024

Could you please clarify what you mean by making it 'configurable'? I'm not sure if I fully understand.

https://o3-docs.openmrs.org/docs/configuration-system

@ciaranduffy
Copy link

Hi @denniskigen, we don't use icons in the RefApp designs. However, if an implementation really wants to use icons, we would recommend using the default Carbon Design left nav item component, with the icon variation. You can see that documented here.

The screenshot above doesn't look like it's using the default carbon left nav component as the icon doesn't look correctly aligned.

@shishiro26
Copy link
Author

The screenshot above doesn't look like it's using the default carbon left nav component as the icon doesn't look correctly aligned.

Hi @ciaranduffy I took the design from the documentation shared in the ticket (Google Docs), as it was mentioned there.

we would recommend using the default Carbon Design left nav item component, with the icon variation. You can see that documented here.

yes sir there was a mistake from my side I will update the icon with the carbon react-icons and remove the hardcoded icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants