RA-2036 - Provide a mechanism for modules to extend the merge visits … #224
Conversation
…functionality via actions
|
@mogoodrich - I updated the description with a link to the ticket. I think this is right? |
|
|
||
| @Override | ||
| public void removeVisitMergeAction(VisitMergeAction visitMergeAction) { | ||
| if (this.visitMergeActions == null) { |
There was a problem hiding this comment.
Do we intentionally ignore cases where one tries to remove a visit merge action when we do not have any?
There was a problem hiding this comment.
@dkayiwa I just followed exactly the same pattern as is already in place for the PatientMergeActions. I figured it was best to stay consistent.
api/src/main/java/org/openmrs/module/emrapi/merge/VisitMergeAction.java
Outdated
Show resolved
Hide resolved
| @@ -121,6 +124,11 @@ public List<PatientMergeAction> getPatientMergeActions() { | |||
| return patientMergeActions; | |||
| } | |||
|
|
|||
| // for testing | |||
| public List<VisitMergeAction> getVisitMergeActions() { | |||
There was a problem hiding this comment.
How about getting rid of this method and use reflection to access the property in the test?
There was a problem hiding this comment.
Again, this is just copying the existing pattern in place. I've changed the method scope to be narrower, so it is no longer a public method. but I see no harm in this method being here...
…functionality via actions
https://openmrs.atlassian.net/browse/RA-2036