EA-194: REST API url should have same standard prefix as other REST e… #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndpoints in OpenMRS
mseaton
approved these changes
Jul 11, 2024
| @@ -16,7 +16,7 @@ | |||
| import javax.servlet.http.HttpServletResponse; | |||
|
|
|||
| @Controller | |||
| @RequestMapping(value = "/rest/emrapi/configuration") | |||
| @RequestMapping(value = "/rest/**/emrapi/configuration") | |||
There was a problem hiding this comment.
This hasn't been released, so in theory we could just use v1, but this makes sense regardless I think until there is actually a v2+
There was a problem hiding this comment.
Fair enough, I'm just going to merge this in, but feel free to change when you finalize your PR
| @@ -19,7 +19,7 @@ | |||
| import org.springframework.web.bind.annotation.ResponseBody; | |||
|
|
|||
| @Controller | |||
| @RequestMapping(value = "/rest/emrapi/inpatient") | |||
| @RequestMapping(value = "/rest/**/emrapi/inpatient") | |||
There was a problem hiding this comment.
Ditto. Not really an issue, as I think this controller / endpoint is going to go away once my PR is ready...
|
Thanks @mseaton , yeah, feel free to rework the ones your actively working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndpoints in OpenMRS
https://openmrs.atlassian.net/browse/EA-194