FM2-651: Allow DAOs access to all API load-able by the OpenMRS Class loader.

[Ruhanga]

Description of what I changed

Issue I worked on

see https://openmrs.atlassian.net/browse/FM2-651

Checklist: I completed these to help reviewers :)

• My IDE is configured to follow the code style of this project.
• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)
• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.
• All new and existing tests passed.
• My pull request is based on the latest changes of the master branch.

[ibacher]

So, a couple of things here:

1. For FHIR module PRs we usually want to have tests so we don't regress on the issue
2. Doing this in the DAO layer feels off to me; it would be preferable to do it somewhere centrally, maybe in the servlet itself, e.g., overwriting the service() method to something like Thread.currentThread().setContextClassLoader(OpenmrsClassLoader.getInstance()); super().
3. Have you tried this and does this actually fix the issue? The reason I ask is that the getSearchResultsCount() method is called before getSearchResults() and I'd expect we'd need to the same fix for createOrUpdate() and delete() as well.

[Ruhanga]

Have you tried this and does this actually fix the issue?

Yes.

Doing this in the DAO layer feels off to me; it would be preferable to do it somewhere centrally, maybe in the servlet itself, e.g., overwriting the service() method to something like Thread.currentThread().setContextClassLoader(OpenmrsClassLoader.getInstance()); super().

I initially wanted to ensure that the ContextClassLoader was set correctly when the DAO layer was called. However, after reconsidering, I realized this wasn’t strictly necessary. As a result, I’ve implemented the suggested approach, which works just as well.