Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove eval calls introduced by depd wrapped functions #410

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

Some dependencies of Next.js (raw-body and send) use depd to deprecate some of their functions,
depd uses eval to generate a deprecated version of such functions, this causes eval warnings in
the terminal even if these functions are never called, the changes here by patching the depd wrapfunction
function so that it still retains the same type of behavior but without using eval

fixes #291

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: 65a0daf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Feb 25, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@410

commit: 65a0daf

@dario-piotrowicz
Copy link
Contributor Author

Note

ideally we should have some e2e tests that check that there are no eval warnings when running the pages-router and app-pages-router apps, however that is not possible with our current implementation, we should consider adding such tests potentially as part of #331

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dario-piotrowicz dario-piotrowicz merged commit d30424b into main Feb 25, 2025
7 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/291/remove-depd-evals branch February 25, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate e2e failures
2 participants