Factor out handling of filer_id. Add more IEC data. #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| state: row['tran_state'], | ||
| zip: row['tran_zip4']) | ||
| .first_or_initialize | ||
| .tap { |p| p.update_attributes(employer: row['tran_emp'], occupation: row['tran_occ']) } |
There was a problem hiding this comment.
So here we're creating Party::Individual records despite the fact that row['entity_cd'] is actually 'Other'. What exactly is this getting us?
There was a problem hiding this comment.
This needs a comment. I was fixing this when the other stuff came op. Forgot about it.
The Firemans Union PAC reported all the contributions from members as OTH. That makes them look like a business rather than a person.
On Nov 1, 2014, at 6:30 PM, Tom Dooner [email protected] wrote:
In backend/fetchers/contribution.rb:
# contributor is "Other"Party::Other.where(name: row['tran_naml'] || 'unknown').first_or_initialize.tap { |p| p.update_attributes(city: row['tran_city'], state: row['tran_state'], zip: row['tran_zip4']) }when 'IND', 'OTH'if row['entity_cd'] == 'IND' || !row['tran_namf'].nil? the# contributor is an Individualfull_name = row.values_at('tran_namf', 'tran_naml', 'tran_nams').join(' ').stripParty::Individual.where(name: full_name,city: row['tran_city'],state: row['tran_state'],zip: row['tran_zip4']).first_or_initialize.tap { |p| p.update_attributes(employer: row['tran_emp'], occupation: row['tran_occ']) }—
Reply to this email directly or view it on GitHub.
|
Cool – I pulled this locally and it seems to work. I didn't see any problems with your code, though using semicolons in Ruby is unnecessary, and so too is the "then" in I'll merge this and deploy it. |
tdooner
added a commit
that referenced
this pull request
Nov 2, 2014
Factor out handling of filer_id. Add more IEC data.
|
Done. Here's the output when I ran it: Thanks for adding this stuff. It adds a whole new dimension to the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #311 issues.
Factor out the handling of filer_id (usually the recipient of a contribution):
There are committee ids which are not integers, map them to unique integers.
Make sure we update pending ids when we find them.
Add the IEC info from form 496
Special case Kaplan, since there is an IEC that matches better than her committee.
Update map.csv (early and often).