Refactor Fetching structure #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main idea is to separate the downloading of the data from the processing of it, under the assumption that the Cal-Access data will be similar enough that it can be massaged into something looking like it came from Socrata without too much hassle. So, there are Downloaders (of which there will be two - Socrata and Cal-Access) and Fetchers (a bad name, but they process the downloaded data). Also, this adds a preliminary amount of test coverage for the most basic processing conditions, and hopefully this will give us all some motivation to be more conscious about writing tests when we find bugs. I ripped out FactoryGirl and replaced it with parsing raw JSON dumps, which seems easier to understand.
|
Cool, travis CI works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to separate the downloading of the data from the
processing of it, under the assumption that the Cal-Access data will be
similar enough that it can be massaged into something looking like it
came from Socrata without too much hassle.
So, there are Downloaders (of which there will be two - Socrata and
Cal-Access) and Fetchers (a bad name, but they process the downloaded
data).
Also, this adds a preliminary amount of test coverage for the most basic
processing conditions, and hopefully this will give us all some
motivation to be more conscious about writing tests when we find bugs. I
ripped out FactoryGirl and replaced it with parsing raw JSON dumps,
which seems easier to understand.