Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payments #371

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Add Payments #371

merged 1 commit into from
Feb 3, 2015

Conversation

mikeubell
Copy link
Contributor

This adds a pie chart of payments by the candidates. You can click on the chart to drill down to the actual payments.

@@ -180,6 +180,36 @@ class << self
CategoryContribution.all.to_json
end

get '/api/payments/?:id?' do |id|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using id in the where clause, the path should be /api/payments/:id as the id is not actually optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@tdooner
Copy link
Member

tdooner commented Feb 1, 2015

Seems good. No blockers.

mikeubell added a commit that referenced this pull request Feb 3, 2015
@mikeubell mikeubell merged commit 905b22a into openoakland:master Feb 3, 2015
@spjika spjika removed the in progress label Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants