0.4.0 examples patch #740
0.4.0 examples patch #740
Conversation
* removing uneeded fields from conditional * removing uneeded fields from conditional * removing uneeded fields from conditional * adding in required fields
* removing min and max from shares where exact is present swapping 2 letter iso country for 3 digit swapping 2 letter iso country for 3 digit fixing shares and componentRecords fixing midindent removing duplicate statement Id fixing midindent fixing shares fixing component records * examples fixes * examples fixes * removing broken link * readding broken link * Update listed-company-exempt-from-disclosure.json entity didn't have hasPublicListing true * fixing indentation * Update multiple-indirect-ownership.json making statementDate consistent * Update multiple-tax-residencies.json making dates consistent --------- Co-authored-by: kd-ods <[email protected]>
There was a problem hiding this comment.
@kathryn-ods - let's not backport the change to statement.json to the 0.4.0 branch. It's a normative change to the schema and so would require a patch release.
Can you remove that from this branch?
This reverts commit cd357cf.
Apologies - think that was bundled with another commit and I accidentally added it. Reverted now |
There was a problem hiding this comment.
This looks good.
(And I've just checked: I don't think any of the updated JSON files are actually the ones embedded in the BODS docs page... so we don't even need to check the rebuild of the ReadTheDocs project.)
|
On merging this, we can close #738 |
Overview
What does this pull request do?
cherry picking from main
fixes errors in the 0.4.0 branch examples and sets up plausible tracking
How can a reviewer test or examine your changes?
I have run these through the DRT tool and checked these are the same as main
Who is best placed to review it?
Closes #
Translations
translating. See the Handbook
Documentation & Release