Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSD metric #4

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Add JSD metric #4

merged 3 commits into from
Aug 26, 2024

Conversation

sainirmayi
Copy link
Contributor

@sainirmayi sainirmayi commented Jul 29, 2024

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality (new method, new metric, ...)
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@sainirmayi sainirmayi requested a review from rcannood July 29, 2024 07:19
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM!

src/metrics/jsd/config.vsh.yaml Outdated Show resolved Hide resolved
src/metrics/jsd/config.vsh.yaml Show resolved Hide resolved
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sainirmayi sainirmayi merged commit 6b25bf9 into main Aug 26, 2024
2 checks passed
@sainirmayi sainirmayi deleted the add_jsd branch August 26, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants