-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: many improvements to the NGINX module config script. #1577
Open
thibaultcha
wants to merge
1
commit into
openresty:master
Choose a base branch
from
thibaultcha:refactor/config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
refactor/config
branch
4 times, most recently
from
August 22, 2019 18:05
3d99b6c
to
17a67d2
Compare
This was referenced Aug 22, 2019
thibaultcha
force-pushed
the
refactor/config
branch
from
August 27, 2019 21:15
17a67d2
to
7cd6b38
Compare
thibaultcha
force-pushed
the
refactor/config
branch
4 times, most recently
from
August 29, 2019 17:20
e7dd803
to
b88e1fe
Compare
This is a major refactor of the `config` script of this module. * The script is now compatible for both ngx_http_lua and ngx_stream_lua * ngx_sream_lua can now be compiled as a dynamic module * The script is able to skip many steps if another Lua module has previously been configured, which avoids many redundant operations and duplicated compilation flags * The script now automatically detects source files in the `src/` directory * Large refactor for improved maintainability * Force `pcre_version` symbol * Fixed an issue on Darwin for static PCRE builds * Require the symbol to be defined for linking * Smarter linker flags detection depending on platform * Require LuaJIT with FFI * Fixed an issue on Darwin which prevented the test form ever succeeding; it now statically links before running to avoid an issue with the .dylib location * Align error messages with NGINX core's style (no indentation) * Added a vi modeline
thibaultcha
force-pushed
the
refactor/config
branch
from
September 24, 2019 19:36
b88e1fe
to
7e33d48
Compare
This pull request is now in conflict :( |
zhuizhuhaomeng
force-pushed
the
master
branch
from
September 20, 2021 11:01
f924579
to
fef2581
Compare
This pull request is now in conflict :( |
This pull request is now in conflict :( |
This pull request is now in conflict :( |
This pull request is now in conflict :( |
This pull request is now in conflict :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of the
config
script of this module.previously been configured, which avoids many redundant operations and
compilation flags
src/
directory
pcre_version
symbolsucceeding; it now statically links before running to avoid an
issue with the
.dylib
location