Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: many improvements to the NGINX module config script. #1577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thibaultcha
Copy link
Member

@thibaultcha thibaultcha commented Aug 22, 2019

This is a major refactor of the config script of this module.

  • The script is now compatible for both ngx_http_lua and ngx_stream_lua
  • ngx_sream_lua can now be compiled as a dynamic module
  • The script is able to skip many steps if another Lua module has
    previously been configured, which avoids many redundant operations and
    compilation flags
  • The script now automatically detects source files in the src/
    directory
  • Large refactor for improved maintainability
  • Force pcre_version symbol
    • Fixed an issue on Darwin for static PCRE builds
    • Require the symbol to be defined for linking
    • Smarter linker flags detection depending on platform
  • Require LuaJIT with FFI
    • Fixed an issue on Darwin which prevented the test from ever
      succeeding; it now statically links before running to avoid an
      issue with the .dylib location
  • Added a vi modeline

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

This is a major refactor of the `config` script of this module.

* The script is now compatible for both ngx_http_lua and ngx_stream_lua
* ngx_sream_lua can now be compiled as a dynamic module
* The script is able to skip many steps if another Lua module has
  previously been configured, which avoids many redundant operations and
  duplicated compilation flags
* The script now automatically detects source files in the `src/`
  directory
* Large refactor for improved maintainability
* Force `pcre_version` symbol
    * Fixed an issue on Darwin for static PCRE builds
    * Require the symbol to be defined for linking
    * Smarter linker flags detection depending on platform
* Require LuaJIT with FFI
    * Fixed an issue on Darwin which prevented the test form ever
      succeeding; it now statically links before running to avoid an
      issue with the .dylib location
* Align error messages with NGINX core's style (no indentation)
* Added a vi modeline
@mergify
Copy link

mergify bot commented Jun 26, 2020

This pull request is now in conflict :(

@mergify
Copy link

mergify bot commented Mar 20, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Mar 20, 2023
@mergify mergify bot removed the conflict label May 10, 2023
@mergify
Copy link

mergify bot commented May 10, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflict label May 10, 2023
@mergify mergify bot removed the conflict label Sep 23, 2023
@mergify
Copy link

mergify bot commented Sep 23, 2023

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Sep 23, 2023
@mergify mergify bot removed the conflict label Mar 6, 2024
Copy link

mergify bot commented Mar 6, 2024

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Mar 6, 2024
@mergify mergify bot removed the conflict label May 27, 2024
Copy link

mergify bot commented May 27, 2024

This pull request is now in conflict :(

@mergify mergify bot added the conflict label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant