Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Java 11 requirement brought in by misk #13

Merged

Conversation

timtebeek
Copy link
Contributor

Copied over the generated templates and removed the misk dependency to remove the runtime requirement on Java 11+.

This then allows the Micrometer recipes to be included with our Spring Boot migrations again, as seen on

@timtebeek timtebeek self-assigned this Aug 12, 2024
@timtebeek
Copy link
Contributor Author

Notably we still retain the rewrite-templating dependency and use of Semantics.expression on these lines using micrometer only:

m = expression(
this, "micrometerCounter",
(String name, String help) -> Counter.builder(name).description(help).register(Metrics.globalRegistry)
).build().apply(getCursor(),

@timtebeek
Copy link
Contributor Author

The trade off here is a little more maintenance burden on that one NoExplicitEmptyLabelList recipe, for the benefit of having micrometer migration recipes be part of our Spring Boot upgrades again. I think that's valid enough to proceed.

@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Aug 12, 2024
@timtebeek timtebeek changed the title Drop Java 11 requirement brought in my misk Drop Java 11 requirement brought in by misk Aug 12, 2024
@timtebeek timtebeek merged commit cc5a723 into main Aug 12, 2024
2 checks passed
@timtebeek timtebeek deleted the drop-misk-java-11-requirement-for-inclusion-with-spring branch August 12, 2024 17:56
timtebeek added a commit to openrewrite/rewrite-spring that referenced this pull request Aug 12, 2024
timtebeek added a commit to openrewrite/rewrite-spring that referenced this pull request Aug 12, 2024
kmccarp pushed a commit to kmccarp/rewrite-micrometer that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

rewrite-micrometer has a runtime requirement of Java 11
1 participant