Migrate doAfterSuccessOrError to tap
#9
Draft
+626
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/reactive/reactor/ReactorDoAfterSuccessOrErrorToTapTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/reactive/reactor/ReactorDoAfterSuccessOrErrorToTapTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/reactive/reactor/ReactorDoAfterSuccessOrErrorToTapTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Oct 9, 2024
Comment on lines
+49
to
+54
| if (error != null) { | ||
| System.out.println("error" + error); | ||
| } else { | ||
| System.out.println("success" + result); | ||
| } | ||
| System.out.println("other logs"); |
There was a problem hiding this comment.
Great start I think to split out commands in this way; let's add a few more variants like if (error == null), if (null == error), or separate ifs, no else, other statements before/interspersed. We're going for a bit of variety here, such that we don't overfit the recipe implementation to this one test. Then from there we can look across OSS projects that use doAfterSuccessOrError.
There was a problem hiding this comment.
I already ran a FindMethods across OSS and found none, but perhaps pattern reactor.core.publisher.Mono doAfterSuccessOrError(..) is too specific?
Will add more test variations!
…e to tap only existing from 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
Further improving coverage of 3.5 and 3.6 deprecations as seen here https://projectreactor.io/docs/core/3.4.39/api/deprecated-list.html
Anything in particular you'd like reviewers to focus on?
Test coverage
Setup of the recipe
Anyone you would like to review specifically?
@OlegDokuka
@timtebeek
Checklist