Prevent NPE on UpgradeSpringFrameworkDependencies.newVersion (#390)

* Prevent NPE on `UpgradeSpringFrameworkDependencies.newVersion` * added test * missing header * Delete UpgradeSpringFrameworkDependenciesTest.java --------- Co-authored-by: joanvr <[email protected]>
openrewrite · Jul 17, 2023 · 56d60e0 · 56d60e0
1 parent c40f54e
commit 56d60e0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/org/openrewrite/java/spring/framework/UpgradeSpringFrameworkDependencies.java b/src/main/java/org/openrewrite/java/spring/framework/UpgradeSpringFrameworkDependencies.java
@@ -45,8 +45,8 @@ public String getDescription() {
     String newVersion;
 
     @Override
-    public Validated validate() {
-        Validated validated = super.validate();
+    public Validated<Object> validate() {
+        Validated<Object> validated = super.validate();
         validated = validated.and(Semver.validate(newVersion, null));
         return validated;
     }
@@ -81,7 +81,7 @@ public List<Recipe> getRecipeList() {
         for (String artifact : artifacts51) {
             result.add(new UpgradeDependencyVersion("org.springframework", artifact, newVersion, null, false, null));
         }
-        if (newVersion.startsWith("5.3")) {
+        if (newVersion != null && newVersion.startsWith("5.3")) {
             result.add(new UpgradeDependencyVersion("org.springframework", "spring-r2dbc", newVersion, null, false, null));
         }