UseNewRequestMatchers should also replace with 5.7 on classpath #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified locally with |
timtebeek
commented
Jul 27, 2023
...tWithSpringSecurity_5_8/java/org/openrewrite/spring/security5/UseNewRequestMatchersTest.java
Outdated
Show resolved
Hide resolved
timtebeek
commented
Jul 27, 2023
Comment on lines
-97
to
-99
| return methods.stream() | ||
| .filter(m -> m.getName().equals("requestMatchers")) | ||
| .filter(m -> m.getParameterTypes().equals(parameterTypes)) |
There was a problem hiding this comment.
This lookup failed, as at recipe runtime only the 5.7 class is available, meaning no replacement method was found. The recipes tests hid that fact, by using classpathResources of 5.8+.
timtebeek
commented
Jul 27, 2023
src/main/java/org/openrewrite/java/spring/security5/UseNewRequestMatchers.java
Outdated
Show resolved
Hide resolved
timtebeek
commented
Jul 27, 2023
src/main/java/org/openrewrite/java/spring/security5/UseNewRequestMatchers.java
Outdated
Show resolved
Hide resolved
sambsnyd
reviewed
Jul 27, 2023
...tWithSpringSecurity_5_8/java/org/openrewrite/spring/security5/UseNewRequestMatchersTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/spring/security5/UseNewRequestMatchers.java
Outdated
Show resolved
Hide resolved
shanman190
reviewed
Jul 27, 2023
...tWithSpringSecurity_5_8/java/org/openrewrite/spring/security5/UseNewRequestMatchersTest.java
Outdated
Show resolved
Hide resolved
joanvr
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Adopt JavaTemplate to replace methods.
What's your motivation?
Replacements failed as we looked for a replacement method in the target type, but only 5.7 classes were available, leading to a mismatch and thus no replacement. Fixes #350
Anything in particular you'd like reviewers to focus on?
Called out below.