removed autoformat when no necessary #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanvr
commented
Aug 8, 2023
src/testWithSpringBoot_2_1/java/org/openrewrite/java/spring/NoRequestMappingAnnotationTest.java
Show resolved
Hide resolved
timtebeek
reviewed
Aug 8, 2023
src/main/java/org/openrewrite/java/spring/NoRequestMappingAnnotation.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Remove the call to maybeAutoFormat on some places
What's your motivation?
Autoformat in some places it's not strictly needed, due to the produced changes, and because the limited scope of the autoFormat it can lead to unwanted results.
Anything in particular you'd like reviewers to focus on?
I've added couple of tests to check for extra scenarios, but maybe I missed some corner case where the autoFormat was needed
Anyone you would like to review specifically?
@timtebeek @rpau
Have you considered any alternatives or workarounds?
Maybe trying to fix the AutoFormat (more specifically the TabsAndIndentsVisitor) could be a better fix, but it seems kinda tricky and complex thing to do, with much bigger (and hard to test) impact.
Checklist