Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test purpose only]Attempt to fix CI #431

Closed
wants to merge 2 commits into from
Closed

[Test purpose only]Attempt to fix CI #431

wants to merge 2 commits into from

Conversation

kunli2
Copy link
Contributor

@kunli2 kunli2 commented Sep 7, 2023

We are seeing CI build failure caused by failing tests

UpdateMysqlDriverArtifactIdTest > Gradle > switchArtifactIdAndUpdateVersionNumber() FAILED
    java.lang.AssertionError: [Recipe validation must have no failures] 
    Expecting no elements of:
      [[Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@9748ae0c'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@9748ae0c'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@9748ae0b'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@9748ae0a'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@9748ae09'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@9748ae08'},

Trying to fix it by reverting some changes recently.

@sambsnyd
Copy link
Member

sambsnyd commented Sep 7, 2023

@kunli2 the failures reproduce locally. Debug through Recipe.validate() to figure out why it is failing

@kunli2
Copy link
Contributor Author

kunli2 commented Sep 7, 2023

Hmm, I can not reproduce it locally

@timtebeek timtebeek closed this Sep 11, 2023
@timtebeek
Copy link
Contributor

For context: that change was made after we kept seeing intermittent classgraph related out of memory issues. Indeed did not show locally; curious how that fails on GHA. :/

@timtebeek timtebeek deleted the kunli/try-fix-ci branch September 14, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants