Attempt not to run boot upgrade 1.x -> 2.x for projects on 2.x already #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmck257
reviewed
Jul 15, 2024
| - org.openrewrite.java.dependencies.DependencyInsight: | ||
| groupIdPattern: org.springframework | ||
| artifactIdPattern: spring-core | ||
| version: 4.x | ||
| recipeList: |
There was a problem hiding this comment.
I'd like to move this precondition to a narrower subrecipe -- right now, it's fully halting the "chain" of each upgrade recipe calling the previous, It also means that recipes such as SpringBoot2BestPractices are no longer run for projects starting on newer Spring versions, which is perhaps unexpected and I'd say undesirable.
Maybe I move the precondition to MigrateHibernateConstraintsToJavax? Any concerns @BoykoAlex ?
There was a problem hiding this comment.
I think that still makes the unit test that I've added to pass. Perhaps we can narrow down the check as well to jakarta.validation-api transient dependency presence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542
Used
preconditionsif spring-core is 4.x then we can upgrade to boot 2.x