Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classifier on dependency added migrating LocalServerPort #544

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

eocantu
Copy link
Contributor

@eocantu eocantu commented Jun 22, 2024

What's changed?

Removes classifier setting on dependency added when migrating LocalServerPort

What's your motivation?

Fixes #541

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review June 23, 2024 08:51
@timtebeek timtebeek added bug Something isn't working boot-2.0 labels Jun 23, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making not just the code change, but also adding a test to verify correct handling going forward. I've added some small touch ups to verify the dependency is added, with the correct scope. Good to see this fixed.

@timtebeek timtebeek merged commit 62e0194 into openrewrite:main Jun 23, 2024
2 checks passed
@eocantu eocantu deleted the fix-migrate-local-server-port branch June 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-2.0 bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Maven dependency added with invalid classifier when using LocalServerPort
2 participants