Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Apache commons-lang3 migration with Spring Boot 2.0 ugprade #603

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

Laurens-W
Copy link
Contributor

Anyone you would like to review specifically?

@timtebeek

Any additional context

Spring manages the version since boot2: https://github.com/spring-projects/spring-boot/blob/2.0.x/spring-boot-project/spring-boot-dependencies/pom.xml#L50
And not in 1.5: https://github.com/spring-projects/spring-boot/blob/1.5.x/spring-boot-dependencies/pom.xml

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek changed the title Include apache commons lang 3 migration Include Apache commons-lang3 migration with Spring Boot 2.0 ugprade Oct 14, 2024
@timtebeek timtebeek self-requested a review October 14, 2024 09:43
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to see this included; about time folks moved over.

@timtebeek timtebeek merged commit c76b972 into main Oct 14, 2024
2 checks passed
@timtebeek timtebeek deleted the add-commons-lang-2-3 branch October 14, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-2.0 recipe Recipe requested
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants