Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: initial commit #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: initial commit #1

wants to merge 4 commits into from

Conversation

ca-d
Copy link
Contributor

@ca-d ca-d commented Jun 26, 2023 •
edited
Loading

Add the initial version of the oscd-tree-grid component.

Note: An NPM_TOKEN secret must be set before merging this into main for the release-please action to actually publish a release to npm.

@ca-d ca-d added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Jun 26, 2023
@ca-d ca-d self-assigned this Jun 26, 2023
@ca-d ca-d force-pushed the oscd-tree-grid branch 3 times, most recently from b4f72a1 to d365353 Compare June 26, 2023 11:38
ca-d added 2 commits June 27, 2023 14:22
@ca-d
fix: increase filter field input debounce time
ecc10b4 
Increases the debounce timeout from 100ms to 250ms in order to give a
noticeable debounce for the average professional typist, according to
napkin calculations done here:
atom/fuzzy-finder#156
@ca-d
0.0.1-alpha.12
4e6f881
@danyill
Copy link

danyill commented Jun 27, 2023

I would be very pleased to learn by reviewing this. If successful and having invested this effort I would also be happy to be a maintainer for this plugin.

For three reasons:

  • I think it is better use of resources for Christian to work on other things.
  • Tree structures are super important to us in IEC 61850 so handling them well is important. We also need a replacement for the existing approach we use for constructing datasets for example (which has a problematic UI).
  • I'm sure there is much here for me to learn.

However I don't see my way clear to look at this any time in the next month or so, so if this is still there when my path is a little clearer I will be delighted to take a somewhat careful look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyill danyill Awaiting requested review from danyill

@JakobVogelsang JakobVogelsang Awaiting requested review from JakobVogelsang

Assignees

@ca-d ca-d

Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ca-d @danyill