Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.2 #37

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Version 0.2 #37

merged 2 commits into from
Aug 13, 2024

Conversation

AHReccese
Copy link
Member

Reference Issues/PRs

#12 #13 #21

What does this implement/fix? Explain your changes.

Version 0.2 release PR

Any other comments?

@AHReccese AHReccese added this to the DMeta v0.2 milestone Aug 12, 2024
@AHReccese AHReccese self-assigned this Aug 12, 2024
@AHReccese AHReccese marked this pull request as ready for review August 12, 2024 01:52
This was linked to issues Aug 12, 2024
support (.pptx) format #12
Closed
support (.xlsx) format #13
Closed
ability to save in-file or copy #21
Closed
sadrasabouri
sadrasabouri requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change request.

CHANGELOG.md Outdated
Comment on lines 50 to 52
[0.1]: https://github.com/openscilab/dmeta/compare/9a4ad10...v0.1
[0.2]: https://github.com/openscilab/dmeta/compare/v0.1...v0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order should be new to old:

[Unreleased]: ...
[0.2]: ...
[0.1]: ...

@AHReccese AHReccese requested a review from sadrasabouri August 12, 2024 02:54
@AHReccese
Copy link
Member Author

Guys, after reviewing it, please do not merge it.

@AHReccese
Copy link
Member Author

AHReccese commented Aug 12, 2024 •
edited
Loading

I might have a very minor PR (not sure, reviewing every single detail)

@sadrasabouri
Copy link
Member

Remember to update release with current dev.

@AHReccese
Copy link
Member Author

Remember to update release with current dev.
@sadrasabouri
Is it necessary? I think there is no conflict here.

@sadrasabouri
Copy link
Member

Remember to update release with current dev.
@sadrasabouri
Is it necessary? I think there is no conflict here.

You can try. But I always wonder merging such a PRs. The dev that release originated from is not the same dev it's merging to.

sepandhaghighi
sepandhaghighi approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AHReccese AHReccese merged commit b4dc33d into dev Aug 13, 2024
42 checks passed
@AHReccese AHReccese deleted the release branch August 13, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadrasabouri sadrasabouri sadrasabouri approved these changes

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@AHReccese AHReccese

Labels
release
Projects
None yet
Milestone
DMeta v0.2
Development

Successfully merging this pull request may close these issues.

ability to save in-file or copy support (.xlsx) format support (.pptx) format
3 participants
@AHReccese @sadrasabouri @sepandhaghighi