Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add standard documents #18

Merged
merged 18 commits into from
Jun 26, 2024
Merged

add standard documents #18

merged 18 commits into from
Jun 26, 2024

Conversation

F-Shahali
Copy link
Collaborator

@F-Shahali F-Shahali commented Jun 14, 2024 •
edited
Loading

Adding standard documents

  • CHANGELOG.md
  • AUTHORS.md
  • README.md
  • RELEASE.md
  • package.json

@F-Shahali F-Shahali changed the title add static files add standard documents Jun 14, 2024
@AHReccese AHReccese added the documentation Improvements or additions to documentation label Jun 15, 2024
@AHReccese AHReccese added this to the mybutton v0.1 milestone Jun 15, 2024
AHReccese
AHReccese requested changes Jun 15, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@AHReccese
Copy link
Member

AHReccese commented Jun 15, 2024 •
edited
Loading

@F-Shahali
Also, fulfill the description of the PR.

@AHReccese
Copy link
Member

@F-Shahali
Let me know when you are done with this PR, so I take care of the rest.

@F-Shahali
Copy link
Collaborator Author

@F-Shahali Also, fulfill the description of the PR.

I just mentioned the files added in this PR.
Other documents have been added before.

@F-Shahali
Copy link
Collaborator Author

@F-Shahali Let me know when you are done with this PR, so I take care of the rest.

It's done. You can go ahead.

@F-Shahali F-Shahali requested a review from AHReccese June 16, 2024 21:36
@AHReccese AHReccese marked this pull request as ready for review June 16, 2024 21:36
AHReccese
AHReccese reviewed Jun 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
AHReccese
AHReccese reviewed Jun 16, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from sepandhaghighi June 16, 2024 23:20
@AHReccese
Copy link
Member

@sepandhaghighi
Dear Sepand, Since we are about to release v0.1 of the MyButton project, and this PR addresses README.md and other standard documents to have in an open-source project, I would appreciate it if you too could kindly review this PR.

sepandhaghighi
sepandhaghighi requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts 💯

Take a look at my comments.
Also, don't forget CNAME file (Example : https://github.com/openscilab/openscilab.github.io/blob/gh-pages/CNAME)

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@AHReccese AHReccese requested a review from sepandhaghighi June 18, 2024 11:51
sepandhaghighi
sepandhaghighi requested changes Jun 19, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from sepandhaghighi June 19, 2024 23:52
sepandhaghighi
sepandhaghighi requested changes Jun 21, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from sepandhaghighi June 21, 2024 22:23
sepandhaghighi
sepandhaghighi approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
@AHReccese Please take a final look, if everything is okay Squash/Merge it after approval.

@AHReccese
Copy link
Member

@F-Shahali
Are you done? if you do, please re-request for review.

@F-Shahali F-Shahali requested a review from AHReccese June 24, 2024 21:19
@AHReccese AHReccese merged commit 5257d01 into dev Jun 26, 2024
1 check passed
@AHReccese AHReccese deleted the static-files branch June 26, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

@AHReccese AHReccese Awaiting requested review from AHReccese

Assignees

@F-Shahali F-Shahali

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
mybutton v0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@F-Shahali @AHReccese @sepandhaghighi