Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengraph tags added #19

Merged
merged 4 commits into from
Jun 20, 2024
Merged

opengraph tags added #19

merged 4 commits into from
Jun 20, 2024

Conversation

AHReccese
Copy link
Member

  • Open Graph Tags added
    Since we haven't a logo yet, logo URLs (either the main one or the large one) are for now filled with placeholders, we will soon have associated logos and update accordingly.

@AHReccese AHReccese added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 18, 2024
@AHReccese AHReccese added this to the mybutton v0.1 milestone Jun 18, 2024
@AHReccese AHReccese requested a review from sepandhaghighi June 18, 2024 16:06
@AHReccese AHReccese self-assigned this Jun 18, 2024
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thank you for your efforts 💯
Please remove trailing slashes (in meta tags)

public/index.html Outdated Show resolved Hide resolved
…ceholder, update og tags, replace https with http
@AHReccese AHReccese requested a review from sepandhaghighi June 20, 2024 00:01
public/index.html Outdated Show resolved Hide resolved
@sepandhaghighi sepandhaghighi removed the documentation Improvements or additions to documentation label Jun 20, 2024
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sepandhaghighi sepandhaghighi merged commit df56744 into dev Jun 20, 2024
1 check passed
@sepandhaghighi sepandhaghighi deleted the opengraph branch June 20, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants