Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.5 #62

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Version 0.5 #62

merged 6 commits into from
Jan 14, 2025

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Jan 8, 2025 •
edited by sepandhaghighi
Loading

Reference Issues/PRs

#47 #51 #52 #53 #54 #55 #56

What does this implement/fix? Explain your changes.

Version 0.5

Any other comments?

@AHReccese AHReccese added this to the mybutton v0.5 milestone Jan 8, 2025
@AHReccese AHReccese self-assigned this Jan 8, 2025
@AHReccese
Copy link
Member Author

AHReccese commented Jan 8, 2025 •
edited
Loading

@F-Shahali
We forgot to update CHANGELOG.md during past PRs, we need to update it before release.
please review and update CHANGELOG.md in this PR.

@AHReccese AHReccese closed this Jan 8, 2025
@AHReccese AHReccese deleted the release branch January 8, 2025 00:55
@AHReccese AHReccese restored the release branch January 8, 2025 00:56
@AHReccese AHReccese reopened this Jan 8, 2025
@AHReccese
Copy link
Member Author

@F-Shahali
I think it is better to release v0.5 after solving 2 more issues, I added Linkedin & Facebook to this release, for now, leave this draft pr, continue solving these issues and after that, I will update this PR.

@F-Shahali
Copy link
Collaborator

F-Shahali commented Jan 8, 2025 •
edited
Loading

@F-Shahali We forgot to update CHANGELOG.md during past PRs, we need to update it before release. please review and update CHANGELOG.md in this PR.

I addressed the LinkedIn & Facebook issues in the latest PR. After approving that, I will update CHANGELOG.md for the new services here.

This was linked to issues Jan 13, 2025
[Feature]: Facebook #51
Closed
[Feature]: LinkedIn #52
Closed
[Feature]: Reddit #53
Closed
[Feature]: Pinterest #54
Closed
[Feature]: Blogger #55
Closed
[Feature]: Trello #56
Closed
sepandhaghighi
sepandhaghighi requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese
It seems you forgot updating the Supported services section in README.md.

F-Shahali
F-Shahali requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@F-Shahali F-Shahali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts.
I left two minor comments.

F-Shahali
F-Shahali reviewed Jan 13, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from F-Shahali January 14, 2025 20:09
sepandhaghighi
sepandhaghighi approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AHReccese AHReccese marked this pull request as ready for review January 14, 2025 23:54
@AHReccese AHReccese merged commit 0bbe765 into dev Jan 14, 2025
3 checks passed
@AHReccese AHReccese deleted the release branch January 14, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F-Shahali F-Shahali F-Shahali approved these changes

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@AHReccese AHReccese

@F-Shahali F-Shahali

Labels
release
Projects
None yet
Milestone
mybutton v0.5
Development

Successfully merging this pull request may close these issues.

[Feature]: Blogger [Feature]: Pinterest [Feature]: Reddit [Feature]: LinkedIn [Feature]: Facebook
[Feature]: Trello
3 participants
@AHReccese @F-Shahali @sepandhaghighi