Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC Clamp Property Added to Primer Class #32

Merged
merged 8 commits into from
Dec 27, 2024
Merged

GC Clamp Property Added to Primer Class #32

merged 8 commits into from
Dec 27, 2024

Conversation

sadrasabouri
Copy link
Member

Reference Issues/PRs

#28

What does this implement/fix? Explain your changes.

gc_clamp attribute added to the Primer class

Any other comments?

🔴 It's odd but the test sample driven from oligoevaluator is different from what the issue and the references says. We should find out what is wrong with either of these sources.

@sadrasabouri sadrasabouri added the enhancement New feature or request label Dec 25, 2024
@sadrasabouri sadrasabouri added this to the opr v0.2 milestone Dec 25, 2024
opr/functions.py Outdated Show resolved Hide resolved
opr/functions.py Outdated Show resolved Hide resolved
opr/functions.py Outdated Show resolved Hide resolved
tests/test_calculations.py Outdated Show resolved Hide resolved
tests/test_calculations.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (09cfd0a) to head (98c2a6f).

Files with missing lines Patch % Lines
opr/primer.py 76.93% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #32      +/-   ##
==========================================
- Coverage   85.00%   84.62%   -0.38%     
==========================================
  Files           5        5              
  Lines         140      156      +16     
  Branches       14       16       +2     
==========================================
+ Hits          119      132      +13     
- Misses         13       15       +2     
- Partials        8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadrasabouri sadrasabouri marked this pull request as ready for review December 25, 2024 23:00
opr/functions.py Outdated Show resolved Hide resolved
tests/test_calculations.py Show resolved Hide resolved
opr/functions.py Outdated Show resolved Hide resolved
@sepandhaghighi sepandhaghighi changed the title GC Clamp Propert Added to Primer Class GC Clamp Property Added to Primer Class Dec 26, 2024
@sepandhaghighi sepandhaghighi removed the request for review from AHReccese December 27, 2024 22:53
@AHReccese
Copy link
Member

@sadrasabouri @sepandhaghighi
Guys I wanted to review this PR, but why you've removed me?

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit d5ed809 into dev Dec 27, 2024
24 checks passed
@sepandhaghighi sepandhaghighi deleted the gc-clamp branch December 27, 2024 23:22
@sepandhaghighi
Copy link
Member

@sadrasabouri @sepandhaghighi Guys I wanted to review this PR, but why you've removed me?

Hi @AHReccese
It's not a major PR and doesn't need two reviewers.
Now you can start your work on #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants