Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single runs #33

Merged
merged 7 commits into from
Dec 30, 2024
Merged

Single runs #33

merged 7 commits into from
Dec 30, 2024

Conversation

AHReccese
Copy link
Member

Reference Issues/PRs

#29

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added this to the opr v0.2 milestone Dec 28, 2024
@AHReccese AHReccese self-assigned this Dec 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (d5ed809) to head (e41607d).

Files with missing lines Patch % Lines
opr/primer.py 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #33      +/-   ##
==========================================
+ Coverage   84.62%   85.09%   +0.47%     
==========================================
  Files           5        5              
  Lines         156      181      +25     
  Branches       16       21       +5     
==========================================
+ Hits          132      154      +22     
- Misses         15       17       +2     
- Partials        9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your efforts 💯
Please take a look at my comments and make the necessary updates to the README.md usage section.

opr/functions.py Outdated Show resolved Hide resolved
opr/functions.py Outdated Show resolved Hide resolved
opr/functions.py Outdated Show resolved Hide resolved
opr/primer.py Outdated Show resolved Hide resolved
opr/primer.py Outdated Show resolved Hide resolved
opr/primer.py Outdated Show resolved Hide resolved
opr/primer.py Outdated Show resolved Hide resolved
opr/primer.py Outdated Show resolved Hide resolved
tests/test_calculations.py Outdated Show resolved Hide resolved
opr/primer.py Outdated Show resolved Hide resolved
opr/primer.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit 3a4c8f0 into dev Dec 30, 2024
24 checks passed
@sepandhaghighi sepandhaghighi deleted the single_runs branch December 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants