-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test #37
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #37 +/- ##
============================================
+ Coverage 88.67% 100.00% +11.34%
============================================
Files 5 5
Lines 150 150
Branches 21 21
============================================
+ Hits 133 150 +17
+ Misses 7 0 -7
+ Partials 10 0 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your efforts, I reviewed everything and it seems great. I just had one comment regarding the cache thing.
I will integrate similar thing to the exception handling test cases in our other libraries, it seems awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about the cache thing in Telegram.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?