Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #37

Merged
merged 12 commits into from
Jan 5, 2025
Merged

Test #37

merged 12 commits into from
Jan 5, 2025

Conversation

sepandhaghighi
Copy link
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Test system modified

Any other comments?

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (062eaa8) to head (1ac81ba).

Additional details and impacted files
@@             Coverage Diff              @@
##              dev       #37       +/-   ##
============================================
+ Coverage   88.67%   100.00%   +11.34%     
============================================
  Files           5         5               
  Lines         150       150               
  Branches       21        21               
============================================
+ Hits          133       150       +17     
+ Misses          7         0        -7     
+ Partials       10         0       -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi self-assigned this Jan 3, 2025
@sepandhaghighi sepandhaghighi added enhancement New feature or request minor test labels Jan 3, 2025
@sepandhaghighi sepandhaghighi added this to the opr v0.2 milestone Jan 3, 2025
@sepandhaghighi sepandhaghighi marked this pull request as ready for review January 3, 2025 14:18
Copy link
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts, I reviewed everything and it seems great. I just had one comment regarding the cache thing.
I will integrate similar thing to the exception handling test cases in our other libraries, it seems awesome.

tests/test_cache.py Show resolved Hide resolved
@AHReccese AHReccese self-requested a review January 5, 2025 00:17
Copy link
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about the cache thing in Telegram.

@AHReccese AHReccese merged commit 1bd5178 into dev Jan 5, 2025
24 checks passed
@AHReccese AHReccese deleted the test branch January 5, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants