Add/websocket #143
Merged
Add/websocket #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testcases updated accordingly
…tion as input + minor refactorings to be more generalized
|
All checks are passed, but for weird reason, the windows python 3.11 fails, as you can see in the attached picture, all tests are passed but the process gets killed, I will re-run this failed job in another time. 
|
sepandhaghighi
requested changes
Oct 22, 2024
…ing` module in order to make it more accessbile
|
I will update |
sepandhaghighi
requested changes
Nov 2, 2024
sepandhaghighi
requested changes
Nov 12, 2024
|
@sepandhaghighi |
sepandhaghighi
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
@AHReccese
Everything looks good to me for now 💯
But remember that we need to manage the versions of pydantic and scipy in the future. If we cannot control their latest versions in the dev-requirements.txt, we should remove them from PyMilo requirement files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#41
In this PR, the ability to use websocket as the communication medium for both client and server side is implemented. but as you know, websocket brings asynchronous context to the board and we do have the ability to let user define for example 3 ml models and push the fit function to the server and wait till get them done. but we need to design a proper mechanism for this purpose. right now it the underlying medium is using websocket and the point is for example that there is one connection instead of connection creation per request to server (like REST protocol).
What does this implement/fix? Explain your changes.
Any other comments?